Re: [PATCH 07/12] iio: pressure: rohm-bm1390: Fix AVE_NUM initialization

Andy Shevchenko <[email protected]> Tue, 11 Aug 2026 13:08:14 +0300

Newsgroups	org.kernel.vger.linux-iio,org.kernel.vger.linux-kernel
Organization	Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo
Message-ID	<[email protected]>

On Tue, Aug 11, 2026 at 12:05:47PM +0300, Matti Vaittinen wrote:
> On 10/08/2026 23:06, Andy Shevchenko wrote:
> > On Mon, Aug 10, 2026 at 10:53:07AM +0300, Matti Vaittinen wrote:

...

> > > Use FIELD_PREP() to shift the intended AVE_NUM value to correct field.
> > 
> > Can it be FIELD_PREP_CONST()?
> 
> Can you please elaborate why it should in this case?

I'm not sure why it's not obvious, but the parameters are constants, why would
we need an additional check or even checks?

-- 
With Best Regards,
Andy Shevchenko