Re: [PATCH v1 1/4] iio: light: Unshadow error codes in ->store()

On Thu Aug 13, 2026 at 3:47 PM CDT
Andy Shevchenko <[email protected]> wrote:

> On Thu, Aug 13, 2026 at 8:52 PM Maxwell Doose <[email protected]> wrote:
>> On Thu Aug 13, 2026 at 2:16 AM CDT
>> Andy Shevchenko <[email protected]> wrote:
>
> ...
>
>> > -#include <linux/kernel.h>
>> >  #include <linux/i2c.h>
>> >  #include <linux/errno.h>
>> >  #include <linux/delay.h>
>> > +#include <linux/kernel.h>
>>
>> Stray change? The ordering's messed up (seems to be case for many of
>> these drivers) so perhaps we can send a patch to fix the ordering.
>
> Not really. I understand what you mean, but I took a step just for the
> k*.h letter to group them. It's slightly easier to follow with

Fair enough :)

> kernel.h being moved. Note, that kernel.h shouldn't be there at all,
> but that is definitely out of scope here.

Makes sense. I wonder if it may be worth doing a patch series removing
all of the kernel.h inclusions in IIO all at once (or maybe some drivers
have a legitimate use for it, but that seems highly unlikely).

thanks,
max

>
>> > +#include <linux/kstrtox.h>
>> >  #include <linux/string.h>
>> >  #include <linux/mutex.h>
>> >  #include <linux/unistd.h>
>
> Thanks for the review!