Re: [PATCH 1/3] iio: imu: adis16480: fix unprotected debugfs reads
Andy Shevchenko <[email protected]>
| Newsgroups | org.kernel.vger.linux-iio,org.kernel.vger.linux-kernel |
|---|---|
| Organization | Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo |
| Message-ID | <[email protected]> |
On Fri, Aug 14, 2026 at 06:07:26PM +0900, Arka Mondal wrote: > The firmware_revision and firmware_date file operations are open coded > and never call debugfs_file_get(), which debugfs_create_file_unsafe() > requires. debugfs_remove_recursive() therefore does not wait for a read > in progress, and unbind frees the iio_dev underneath it. > > Use debugfs_create_file() instead. This one looks correct, but would it be possible to switch to use DEFINE_DEBUGFS_ATTRIBUTE() instead? In case Jonathan wants to apply this Reviewed-by: Andy Shevchenko <[email protected]> ... Also whenever send a series, add cover letter to it. Your patch preparing should be like git format-patch --cover-letter --base ... -v <n> ... where <n> is patch series version number. -- With Best Regards, Andy Shevchenko