Re: [PATCH v4 1/3] iio: imu: inv_icm42600: sort device id tables numerically

On Mon, 10 Aug 2026 21:11:55 +0200
Jorijn van der Graaf <[email protected]> wrote:

> The I2C, SPI and OF device id tables list the parts in the chip enum's
> declaration order, which is neither numeric nor alphabetical. Sort the
> entries numerically by part number so new entries have an unambiguous
> position.
> 
> Suggested-by: Jonathan Cameron <[email protected]>
> Link: https://lore.kernel.org/all/20260724012505.02029e51@jic23-huawei/
> Assisted-by: Claude:claude-fable-5
> Signed-off-by: Jorijn van der Graaf <[email protected]>

Looks good. I used to pick this sort of thing up ahead of series
but I'm not sure we've figured out how to let Sashiko know that
is the case yet. So I'll leave this for when the reset of the
series is ready to go.

Thanks for tidying this up.

Jonathan

> ---
> No changes in v4.
> 
>  drivers/iio/imu/inv_icm42600/inv_icm42600_i2c.c | 16 ++++++++--------
>  drivers/iio/imu/inv_icm42600/inv_icm42600_spi.c | 16 ++++++++--------
>  2 files changed, 16 insertions(+), 16 deletions(-)
> 
> diff --git a/drivers/iio/imu/inv_icm42600/inv_icm42600_i2c.c b/drivers/iio/imu/inv_icm42600/inv_icm42600_i2c.c
> index 28552d2db91d..e44ed6dcde02 100644
> --- a/drivers/iio/imu/inv_icm42600/inv_icm42600_i2c.c
> +++ b/drivers/iio/imu/inv_icm42600/inv_icm42600_i2c.c
> @@ -77,10 +77,10 @@ static const struct i2c_device_id inv_icm42600_id[] = {
>  	{ .name = "icm42600", .driver_data = INV_CHIP_ICM42600 },
>  	{ .name = "icm42602", .driver_data = INV_CHIP_ICM42602 },
>  	{ .name = "icm42605", .driver_data = INV_CHIP_ICM42605 },
> -	{ .name = "icm42686", .driver_data = INV_CHIP_ICM42686 },
>  	{ .name = "icm42622", .driver_data = INV_CHIP_ICM42622 },
> -	{ .name = "icm42688", .driver_data = INV_CHIP_ICM42688 },
>  	{ .name = "icm42631", .driver_data = INV_CHIP_ICM42631 },
> +	{ .name = "icm42686", .driver_data = INV_CHIP_ICM42686 },
> +	{ .name = "icm42688", .driver_data = INV_CHIP_ICM42688 },
>  	{ }
>  };
>  MODULE_DEVICE_TABLE(i2c, inv_icm42600_id);
> @@ -95,18 +95,18 @@ static const struct of_device_id inv_icm42600_of_matches[] = {
>  	}, {
>  		.compatible = "invensense,icm42605",
>  		.data = (void *)INV_CHIP_ICM42605,
> -	}, {
> -		.compatible = "invensense,icm42686",
> -		.data = (void *)INV_CHIP_ICM42686,
>  	}, {
>  		.compatible = "invensense,icm42622",
>  		.data = (void *)INV_CHIP_ICM42622,
> -	}, {
> -		.compatible = "invensense,icm42688",
> -		.data = (void *)INV_CHIP_ICM42688,
>  	}, {
>  		.compatible = "invensense,icm42631",
>  		.data = (void *)INV_CHIP_ICM42631,
> +	}, {
> +		.compatible = "invensense,icm42686",
> +		.data = (void *)INV_CHIP_ICM42686,
> +	}, {
> +		.compatible = "invensense,icm42688",
> +		.data = (void *)INV_CHIP_ICM42688,
>  	},
>  	{ }
>  };
> diff --git a/drivers/iio/imu/inv_icm42600/inv_icm42600_spi.c b/drivers/iio/imu/inv_icm42600/inv_icm42600_spi.c
> index faf743bc6444..3e2f4eb42e97 100644
> --- a/drivers/iio/imu/inv_icm42600/inv_icm42600_spi.c
> +++ b/drivers/iio/imu/inv_icm42600/inv_icm42600_spi.c
> @@ -74,10 +74,10 @@ static const struct spi_device_id inv_icm42600_id[] = {
>  	{ .name = "icm42600", .driver_data = INV_CHIP_ICM42600 },
>  	{ .name = "icm42602", .driver_data = INV_CHIP_ICM42602 },
>  	{ .name = "icm42605", .driver_data = INV_CHIP_ICM42605 },
> -	{ .name = "icm42686", .driver_data = INV_CHIP_ICM42686 },
>  	{ .name = "icm42622", .driver_data = INV_CHIP_ICM42622 },
> -	{ .name = "icm42688", .driver_data = INV_CHIP_ICM42688 },
>  	{ .name = "icm42631", .driver_data = INV_CHIP_ICM42631 },
> +	{ .name = "icm42686", .driver_data = INV_CHIP_ICM42686 },
> +	{ .name = "icm42688", .driver_data = INV_CHIP_ICM42688 },
>  	{ }
>  };
>  MODULE_DEVICE_TABLE(spi, inv_icm42600_id);
> @@ -92,18 +92,18 @@ static const struct of_device_id inv_icm42600_of_matches[] = {
>  	}, {
>  		.compatible = "invensense,icm42605",
>  		.data = (void *)INV_CHIP_ICM42605,
> -	}, {
> -		.compatible = "invensense,icm42686",
> -		.data = (void *)INV_CHIP_ICM42686,
>  	}, {
>  		.compatible = "invensense,icm42622",
>  		.data = (void *)INV_CHIP_ICM42622,
> -	}, {
> -		.compatible = "invensense,icm42688",
> -		.data = (void *)INV_CHIP_ICM42688,
>  	}, {
>  		.compatible = "invensense,icm42631",
>  		.data = (void *)INV_CHIP_ICM42631,
> +	}, {
> +		.compatible = "invensense,icm42686",
> +		.data = (void *)INV_CHIP_ICM42686,
> +	}, {
> +		.compatible = "invensense,icm42688",
> +		.data = (void *)INV_CHIP_ICM42688,
>  	},
>  	{ }
>  };