Re: [PATCH v2 0/2] iio: accel: kionix-kx022a: unify staging buffer and convert to iio_push_to_buffers_with_ts()
Matti Vaittinen <[email protected]>
| Newsgroups | org.kernel.vger.linux-iio,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On 19/08/2026 03:09, Jonathan Cameron wrote: > On Tue, 18 Aug 2026 22:51:20 +0100 > Gabriel Rondon <[email protected]> wrote: > >> v1 was a single patch converting the two push sites to >> iio_push_to_buffers_with_ts(). Reviewing it, Jonathan pointed out that >> the driver carries two separate staging areas holding the same thing >> (buffer[8] and the scan struct), and asked to fold the cleanup into this >> set. >> >> So v2 is a two-patch series: patch 1 drops the redundant buffer and >> routes the one-shot read and the triggered handler through scan, and >> patch 2 does the deprecated-API conversion, now with a single buffer to >> push at both sites. >> >> Changes in v2: >> - New patch 1: drop buffer[8], use scan for the one-shot read and the >> triggered handler, move IIO_DMA_MINALIGN onto scan (Jonathan) >> - Patch 2 now pushes data->scan at both sites instead of data->buffer >> > Nice. All looks good to me, so I'll queue it up. > > Applied to the testing branch of iio.git which will be rebased on rc1 once > available. > > Note that there is plenty of time for additional feedback, tags or indeed > me to drop it again if someone spots something I missed. Ah, Jonathan was quick and efficient :) I'll drop my comments to 'nits' in order to not generate more work for Jonathan. Hence, acting on my comments is not required. -- Matti -- Matti Vaittinen Linux kernel developer at ROHM Semiconductors Oulu Finland ~~ When things go utterly wrong vim users can always type :help! ~~