Re: [PATCH] iio: accel: sca3000: fix frequency divider condition check

Andy Shevchenko <[email protected]> Wed, 19 Aug 2026 16:38:09 +0300

Newsgroups	org.kernel.vger.linux-iio,org.kernel.vger.linux-kernel
Organization	Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo
Message-ID	<[email protected]>

On Wed, Aug 19, 2026 at 12:41:01PM +0100, Salah Triki wrote:
> When setting the sampling frequency, the check for `base_freq / 2` is
> followed by an independent `if` statement for `base_freq / 4`. If `val`
> equals `base_freq / 2`, the second check fails and falls through to the
> `else if (val != base_freq)` branch, returning `-EINVAL` erroneously.
> 
> Fix this by chaining the checks with `else if`.

This needs a Fixes tag.

-- 
With Best Regards,
Andy Shevchenko