Re: [PATCH v4 4/9] iio: dac: mcp47feb02: use dev_dbg for invalid label
Andy Shevchenko <[email protected]>
| Newsgroups | org.kernel.vger.linux-iio,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel |
|---|---|
| Organization | Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo |
| Message-ID | <[email protected]> |
On Wed, Aug 19, 2026 at 03:41:08PM +0300, Ariana Lazar wrote: > Correct unneccesarry probe error returned at an invalid label with a debug > message instead. Why?! ... > ret = fwnode_property_read_string(child, "label", &data->labels[reg]); > if (ret) > - return dev_err_probe(dev, ret, "%pfw: invalid label\n", > - fwnode_get_name(child)); > + dev_dbg(dev, "%s: invalid label\n", fwnode_get_name(child)); My gosh, the patch before this one should really fix the fwnode_get_name() usage here. return dev_err_probe(dev, ret, "%pfw: invalid label\n", child); Otherwise it's a good way to Oops. I haven't checked the rest, but this is how it has to be when %pfw is used. -- With Best Regards, Andy Shevchenko