Re: [PATCH v3 1/5] iio: pressure: ms5637: Add missing ms5803 I2C device ID

On Thu, 20 Aug 2026 10:12:16 -0400
Louis Adamian <[email protected]> wrote:

> meas,ms5803 is in the OF match table with no corresponding entry in
> ms5637_id.
> 
> Fixes: 649ef114a0a0 ("iio:pressure:ms5637: add ms5803 support")

Hi Louis,

What is the result of this entry not being there?   We need
a reason that this is a fix rather than simply a cleanup / consistency
improvement.

> Signed-off-by: Louis Adamian <[email protected]>

Please make sure that a series has a cover letter in future
--cover-letter to git will provide you with one to fill in.

The rest of the thread will end up in reply to that. Brings the
advantage of a place to provide a short overview of what the whole series is up
to; somewhere for comments; and a useful name in tools like patchwork.

Otherwise this looks good to me.

> ---
>  drivers/iio/pressure/ms5637.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/iio/pressure/ms5637.c b/drivers/iio/pressure/ms5637.c
> index be8921644558..4f9f556bd123 100644
> --- a/drivers/iio/pressure/ms5637.c
> +++ b/drivers/iio/pressure/ms5637.c
> @@ -215,6 +215,7 @@ static const struct ms_tp_data ms8607_data = {
>  
>  static const struct i2c_device_id ms5637_id[] = {
>  	{ .name = "ms5637", .driver_data = (kernel_ulong_t)&ms5637_data },
> +	{ .name = "ms5803", .driver_data = (kernel_ulong_t)&ms5803_data },
>  	{ .name = "ms5805", .driver_data = (kernel_ulong_t)&ms5805_data },
>  	{ .name = "ms5837", .driver_data = (kernel_ulong_t)&ms5837_data },
>  	{ .name = "ms8607-temppressure", .driver_data = (kernel_ulong_t)&ms8607_data },