Re: [PATCH v9 3/3] iio: dac: Add AD5529R DAC driver support

On Thu, 20 Aug 2026 09:08:23 +0200
Janani Sunil <[email protected]> wrote:

> Add support for AD5529R 16-channel, 12/16 bit Digital to Analog Converter
> from Analog Devices.
> 
> The device communicates over SPI and supports per-channel output range
> configuration. An optional external 4.096V reference can be used in
> place of the internal reference.
> 
> Signed-off-by: Janani Sunil <[email protected]>
Sashiko calls out that dependency should be on CONFIG_SPI.

I didn't check it's reasoning but I believe the conclusion is correct.
If that's all that comes up, I can tweak whilst applying.

Looks good to me, but I'll leave it on list for a little longer
as we aren't in a rush and others may well want to review.

Thanks,

Jonathan

> ---
>  MAINTAINERS               |   1 +
>  drivers/iio/dac/Kconfig   |  16 ++
>  drivers/iio/dac/Makefile  |   1 +
>  drivers/iio/dac/ad5529r.c | 538 ++++++++++++++++++++++++++++++++++++++++++++++
>  4 files changed, 556 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 320e84765ce6..143714e27d51 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1513,6 +1513,7 @@ L:	[email protected]
>  S:	Supported
>  W:	https://ez.analog.com/linux-software-drivers
>  F:	Documentation/devicetree/bindings/iio/dac/adi,ad5529r.yaml
> +F:	drivers/iio/dac/ad5529r.c
>  
>  ANALOG DEVICES INC AD5706R DRIVER
>  M:	Alexis Czezar Torreno <[email protected]>
> diff --git a/drivers/iio/dac/Kconfig b/drivers/iio/dac/Kconfig
> index 657c68e75542..6a7109f42f2a 100644
> --- a/drivers/iio/dac/Kconfig
> +++ b/drivers/iio/dac/Kconfig
> @@ -134,6 +134,22 @@ config AD5449
>  	  To compile this driver as a module, choose M here: the
>  	  module will be called ad5449.
>  
> +config AD5529R
> +	tristate "Analog Devices AD5529R High Voltage DAC driver"
> +	depends on SPI_MASTER

depends on SPI

> +	select REGMAP_SPI
> +	help
> +	  Say yes here to build support for Analog Devices AD5529R 16-Channel,
> +	  12-Bit/16-Bit, 40V High Voltage Precision Digital to Analog Converter.
> +
> +	  The device features multiple output voltage ranges from -20V to +20V,
> +	  built-in 4.096V voltage reference, and digital functions including
> +	  toggle, dither, and ramp modes. Supports both 12-bit and 16-bit
> +	  resolution variants.
> +
> +	  To compile this driver as a module, choose M here: the
> +	  module will be called ad5529r.
> +