Re: [PATCH v6 0/2] iio: adc: Add support for Texas Instruments ADS112C04

On Fri, Aug 21, 2026 at 9:25 AM Jonathan Cameron <[email protected]> wrote:
>
> On Thu, 20 Aug 2026 15:51:50 +0800
> Kyle Hsieh <[email protected]> wrote:
>
> > This patch series introduces support for the Texas Instruments ADS112C04
> > Analog-to-Digital Converters.
> >
> > The ADS112C04 (16-bit) is precision, low-power, delta-sigma ADCs with
> > an I2C interface. They feature a flexible input multiplexer supporting
> > single-ended and differential measurements, a programmable gain amplifier,
> > and an internal voltage reference.
> >
> > Note: While this chip shares similarities with the ADS112C14 (currently
> > being upstreamed by David Lechner), the register maps and feature sets
> > are sufficiently different to warrant a separate driver. However, the
> > DT bindings and channel parsing logic have been aligned with the
> > ADS112C14 conventions.
> >
> > This initial submission provides a minimal feature set (single-shot
> > conversions and basic DRDY interrupt) covering current use cases.
> >
> > Signed-off-by: Kyle Hsieh <[email protected]>
>
> Sashiko had some feedback on the interrupt - if you are respinning for
> other reasons it might be good to add a comment in the dt-binding about
> it being an edge interrupt. From a quick look at the datasheet a level
> interrupt would not make much sense.
>
Makes sense. Since DRDY is a pulse, an edge trigger is indeed the right
choice. I'll add the note to the binding if I respin, or send it as a
follow-up patch.

Thanks for the review.

Kyle Hsieh