[PATCH v5 0/6] iio: dac: ad5504: bindings, cleanups, locking, and scale fixes
Taha Ed-Dafili <[email protected]>
| Newsgroups | org.kernel.vger.linux-iio,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
Jonathan Cameron applied patches 2 (sort headers alphabetically) and 4 (introduce local dev pointer) from v3 directly to iio/testing. This series rebases on top of that state and does not re-send those patches. This v5 series addresses feedback from the v4 review by Jonathan Cameron, Andy Shevchenko and Uwe Kleine-König: * Drop <linux/mod_devicetable.h> — now covered by spi.h (Andy, Uwe) * Add blank lines after all guard() call sites (Andy) * Rename macro to AD5504_VREF_ACPI_DEFAULT_mV (Andy) * Switch to is_acpi_device_node(dev_fwnode(dev)) (Andy) * Use (MICRO / MILLI) for microvolt-to-millivolt conversions (Andy) * Trim all commit messages (Andy, Jonathan) * Reorder ACPI/DT separation before pdata removal to avoid an intermediate commit that hard-fails probe on regulator-less systems (issue raised by Andy) Testing: Re-verified on ARM64 Raspberry Pi 5 (BCM2712) using a custom Device Tree overlay on spi10, without physical AD5504 hardware. All test cases from v4 pass unchanged with the v5 code: 60V path (output-range-microvolt = <0 60000000>): $ cat /sys/bus/iio/devices/iio:device0/out_voltage_scale 14.648437500 (60000 mV / 4096) 30V path (output-range-microvolt = <0 30000000>): $ cat /sys/bus/iio/devices/iio:device0/out_voltage_scale 7.324218750 (30000 mV / 4096) Invalid range (output-range-microvolt = <0 70000000>): [ 94.762850] ad5504 spi10.0: error -EINVAL: Invalid output-range-microvolt [ 94.762857] ad5504 spi10.0: probe with driver ad5504 failed with error -22 Backward compatibility (no output-range-microvolt, vcc-supply = 60V): $ cat /sys/bus/iio/devices/iio:device0/out_voltage_scale 14.648437500 (60000 mV / 4096 via regulator fallback) Powerdown sysfs read/write and powerdown mode switching (20kohm_to_gnd, three_state) verified on all four channels without errors. Previous versions: v4: https://lore.kernel.org/linux-iio/[email protected]/ v3: https://lore.kernel.org/linux-iio/[email protected]/ v2: https://lore.kernel.org/linux-iio/[email protected]/ v1: https://lore.kernel.org/linux-iio/[email protected]/ Thank you to Jonathan Cameron, David Lechner, Andy Shevchenko, Nuno Sá, Krzysztof Kozlowski, Conor Dooley and Uwe Kleine-König for the continued reviews. Taha Ed-Dafili (6): dt-bindings: iio: dac: ad5504: add output-range and missing gpios iio: dac: ad5504: Align headers with IWYU principle iio: dac: ad5504: separate ACPI and DT paths iio: dac: ad5504: remove legacy platform data support iio: dac: ad5504: introduce local lock to protect state and spi transfers iio: dac: ad5504: support scale via output-range-microvolt property .../bindings/iio/dac/adi,ad5504.yaml | 39 ++++++++- drivers/iio/dac/ad5504.c | 82 +++++++++++++++---- include/linux/iio/dac/ad5504.h | 15 ---- 3 files changed, 103 insertions(+), 33 deletions(-) delete mode 100644 include/linux/iio/dac/ad5504.h -- 2.55.0