[PATCH] iio: core: Avoid BUG() on invalid clock types
Rishab Madhugiri <[email protected]>
| Newsgroups | org.kernel.vger.linux-iio,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
Replace deprecated use of BUG() in default switch cases of iio_get_time_ns() and current_timestamp_clock_show() with WARN_ONCE() and return correct fallback or error codes. Signed-off-by: Rishab Madhugiri <[email protected]> --- drivers/iio/industrialio-core.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c index 767a7794624a..c0411a29fe3f 100644 --- a/drivers/iio/industrialio-core.c +++ b/drivers/iio/industrialio-core.c @@ -341,7 +341,8 @@ s64 iio_get_time_ns(const struct iio_dev *indio_dev) case CLOCK_TAI: return ktime_get_clocktai_ns(); default: - BUG(); + WARN_ONCE(1, "Invalid clock type selected for IIO device\n"); + return 0; } } EXPORT_SYMBOL(iio_get_time_ns); @@ -1518,7 +1519,8 @@ static ssize_t current_timestamp_clock_show(struct device *dev, case CLOCK_TAI: break; default: - BUG(); + WARN_ONCE(1, "Invalid clock type selected for IIO device\n"); + return -EINVAL; } return sysfs_emit(buf, "%s\n", clock_names[clk]); -- 2.43.0