Re: [PATCH 2/3] iio: imu: adis16400: fix unprotected debugfs reads
Andy Shevchenko <[email protected]>
| Newsgroups | org.kernel.vger.linux-iio,org.kernel.vger.linux-kernel |
|---|---|
| Organization | Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo |
| Message-ID | <[email protected]> |
On Sat, Aug 22, 2026 at 10:37:53PM +0100, Jonathan Cameron wrote: > On Sat, 15 Aug 2026 11:42:30 +0300 > Andy Shevchenko <[email protected]> wrote: > > > On Fri, Aug 14, 2026 at 06:07:27PM +0900, Arka Mondal wrote: > > > The serial_number file operations are open coded and never call > > > debugfs_file_get(), which debugfs_create_file_unsafe() requires. > > > debugfs_remove_recursive() therefore does not wait for a read in > > > progress, and unbind frees the iio_dev underneath it. > > > > > > Use debugfs_create_file() instead. > > > > Have you read the code? Have you read the commit message of the "culprit" > > commit? > > > > NAK. Please, revisit all your patches and be careful next time. > > > FWIW it is curious that the original patch didn't touch the serial number > declaration whilst touching the other two. Superficially that looks > like an omission we missed in review. I see, yes, it some strange case of missing piece during review. -- With Best Regards, Andy Shevchenko