Re: [PATCH] iio: core: Avoid BUG() on invalid clock types
Andy Shevchenko <[email protected]>
| Newsgroups | org.kernel.vger.linux-iio,org.kernel.vger.linux-kernel |
|---|---|
| Organization | Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo |
| Message-ID | <[email protected]> |
On Mon, Aug 24, 2026 at 12:05:03PM +0200, Joshua Crofts wrote: > On Mon, 24 Aug 2026 12:55:47 +0300 > Andy Shevchenko <[email protected]> wrote: > > > On Sun, Aug 23, 2026 at 10:25:02PM +0000, Rishab Madhugiri wrote: > > > Replace deprecated use of BUG() in default switch cases of > > > iio_get_time_ns() and current_timestamp_clock_show() with > > > WARN_ONCE() and return correct fallback or error codes. > > > > Why?! > > Because BUG() and BUG_ON() shouldn't be used anymore, no? Linus himself > said that he hates the macros. Why? Please, study the case. As for the above change, there are two questions (at least): - Why BUG() is deprecated? Where is it stated? - What will WARN*() gain us here? (Note some specific kernel command line parameter that may convert WARN to BUG) -- With Best Regards, Andy Shevchenko