Re: [PATCH v2] iio: cros_ec: Convert to DEFINE_SIMPLE_DEV_PM_OPS()
Andy Shevchenko <[email protected]>
| Newsgroups | org.kernel.vger.linux-iio,dev.linux.lists.chrome-platform,org.kernel.vger.linux-kernel |
|---|---|
| Organization | Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo |
| Message-ID | <[email protected]> |
On Tue, Aug 25, 2026 at 09:32:16AM +0700, Triet Hoang wrote: > On Tue, 25 Aug 2026 01:52:20 +0000, Tzung-Bi Shih wrote: > > > This needs to update accordingly: SIMPLE_DEV_PM_OPS() + EXPORT_SYMBOL_GPL() > > -> EXPORT_GPL_SIMPLE_DEV_PM_OPS(). > > > > > This lets us drop the __maybe_unused annotations from the resume callbacks, > > > and reduces kernel size when CONFIG_PM or CONFIG_PM_SLEEP is disabled. > > > > With a nit in the commit message, > > Reviewed-by: Tzung-Bi Shih <[email protected]> > > Thanks for your review. Should I send the v3 to update this? > Or maintainer will 'amend' the commit message when apply patch. Taking into account that I gave also comments (and we have plenty of time), please v3. -- With Best Regards, Andy Shevchenko