Re: [PATCH v5] staging: iio: adc: ad7816: Use modern IIO attribute macros
Andy Shevchenko <[email protected]>
| Newsgroups | org.kernel.vger.linux-iio,dev.linux.lists.linux-staging,org.kernel.vger.linux-kernel |
|---|---|
| Organization | Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo |
| Message-ID | <[email protected]> |
On Fri, Aug 28, 2026 at 01:56:42AM +0600, Md. Mahmudul Hasan Mabud wrote: > Replace the legacy IIO_DEVICE_ATTR() macros with the modern > IIO_DEVICE_ATTR_RW() and IIO_DEVICE_ATTR_RO() macros. > > This includes renaming driver-specific callback functions to > standard <name>_show() and <name>_store() formats. ... > } > Also drop this blank line. Same for other cases. > -static IIO_DEVICE_ATTR(mode, 0644, > - ad7816_show_mode, > - ad7816_store_mode, > - 0); > +static IIO_DEVICE_ATTR_RW(mode, 0); With that being done, I'm fine with the patch Reviewed-by: Andy Shevchenko <[email protected]> -- With Best Regards, Andy Shevchenko