Re: [PATCH 2/4] Input: psmouse - clean up locking around disable_work_sync()
Dmitry Torokhov <[email protected]>
| Newsgroups | org.kernel.vger.linux-input,dev.linux.lists.sashiko-reviews |
|---|---|
| Message-ID | <[email protected]> |
On Mon, Jul 27, 2026 at 05:32:54AM +0000, [email protected] wrote: > Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: > - [High] Moving disable_work_sync() to the top of psmouse_disconnect() breaks the early-abort synchronization in psmouse_resync(), causing delays and queuing stray reconnect events. > -- This is incorrect analysis. Disconnect may happen a millisecond earlier or millisecond later, and setting PSMOUSE_CMD_MODE first would not change anything. We just have to deal with such scenario. Thanks. -- Dmitry