Re: [PATCH v6 0/9] HID: steelseries: split out Arctis driver and add Nova 5X/Nova 7 support
Bastien Nocera <[email protected]>
| Newsgroups | org.kernel.vger.linux-input,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On Wed, 2026-07-08 at 23:23 -0400, Sriman Achanta wrote: > From: Sriman Achanta <[email protected]> > > This series moves the SteelSeries Arctis headset support out of > hid-steelseries.c into its own module, reworks it around a per-model > device_info table, hardens the battery power-supply lifetime, adds an > asynchronous status interface, and finally adds support for the > Arctis > Nova 5X and Nova 7 families. After the split, hid-steelseries.c is > left > handling only the SRW-S1 racing wheel. > > Changes since v5: > - Nova: rename the Gen2-only parse function and device_info to > steelseries_arctis_nova_{parse_status,info} now that they are also > used by the Nova 5X and the 2026 refresh, not just Gen2. > - Nova: add device IDs and a device_info for the original (pre-Gen2) > Arctis Nova 7 family. It answers the same 0xb0/0xb7/0xb9/0xbb > status > opcodes on the same interfaces as Gen2, but reports battery > capacity > as a discrete 0-4 level rather than a raw percentage, so it gets > its > own parse function that maps the level through > steelseries_map_capacity() instead of using it directly. > - Nova: add the Arctis Nova 5X, which shares the Gen2/2026 protocol. > - hid-ids.h: fix a whitespace-only bug where the new Nova 5X macro > was > space-aligned instead of tab-aligned. > - Rebased on current master. > > The Nova 5X protocol was verified against hardware by > [email protected], and the original Nova 7 protocol was > verified > against hardware by [email protected]. Thanks to both for testing. I > previously ommited other devices in the v4 patch series due to being > unable to verify. Tested locally, and reviewed all the patches, looks good to me, thanks for the work Sriman! Reviewed-by: Bastien Nocera <[email protected]> > > Sriman Achanta (9): > HID: steelseries: Fix ARCTIS_1_X device mislabeling > HID: steelseries: Split Arctis headset driver into separate module > HID: steelseries: Inline and simplify SRWS1 wheel driver > HID: steelseries: Refactor Arctis driver to use device_info > framework > HID: steelseries: Report POWER_SUPPLY_STATUS_FULL when full > HID: steelseries: Correct Arctis 9 battery calibration range > HID: steelseries: Manage battery lifetime with refcounting > HID: steelseries: Add async status interface support > HID: steelseries: Add support for Arctis Nova 5X and Nova 7 > families > > drivers/hid/Makefile | 2 +- > drivers/hid/hid-ids.h | 18 +- > drivers/hid/hid-quirks.c | 16 +- > drivers/hid/hid-steelseries-arctis.c | 718 > +++++++++++++++++++++++++++ > drivers/hid/hid-steelseries.c | 406 +-------------- > 5 files changed, 759 insertions(+), 401 deletions(-) > create mode 100644 drivers/hid/hid-steelseries-arctis.c > > > base-commit: 7404ce51637231382873d0b55edabc2f3b841a9d