Re: [PATCH] HID: logitech-hidpp: Remove duplicate ID for the G703 Hero over USB

On Tue, 2026-07-21 at 18:37 +0100, Stuart Hayhurst wrote:
> The ID appears to be given twice, remove the duplicate
> 
> Signed-off-by: Stuart Hayhurst <[email protected]>

Indeed, at line 4652:
        { /* Logitech G703 Hero Gaming Mouse over USB */
          HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC090) },
        { /* Logitech G900 Gaming Mouse over USB */
          HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC081) },
        { /* Logitech G903 Gaming Mouse over USB */
          HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC086) },
        { /* Logitech G Pro Gaming Mouse over USB */
          HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC088) },
        { /* MX Vertical over USB */
          HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC08A) },
        { /* Logitech G703 Hero Gaming Mouse over USB */
          HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC090) },

Benjamin, Jiri, is there not a way to detect duplicates like this?

In any case, looks good to me.

Reviewed-by: Bastien Nocera <[email protected]>

> ---
>  drivers/hid/hid-logitech-hidpp.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-
> logitech-hidpp.c
> index 90b0184df777..b1b1c5cb657c 100644
> --- a/drivers/hid/hid-logitech-hidpp.c
> +++ b/drivers/hid/hid-logitech-hidpp.c
> @@ -4659,8 +4659,6 @@ static const struct hid_device_id
> hidpp_devices[] = {
>  	  HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC088) },
>  	{ /* MX Vertical over USB */
>  	  HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC08A) },
> -	{ /* Logitech G703 Hero Gaming Mouse over USB */
> -	  HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC090) },
>  	{ /* Logitech G903 Hero Gaming Mouse over USB */
>  	  HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC091) },
>  	{ /* Logitech G915 TKL Keyboard over USB */