Re: [PATCH v10 2/7] mfd: Add driver for ASUS Transformer embedded controller

Uwe Kleine-König <[email protected]> Wed, 29 Jul 2026 14:33:59 +0200

Newsgroups	org.kernel.vger.linux-input,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel,org.kernel.vger.linux-leds,org.kernel.vger.linux-pm
Message-ID	<amnxliqWscD4Mjdz@monoceros>

On Sat, Jul 25, 2026 at 04:23:13PM +0300, Svyatoslav Ryhel wrote:
> чт, 23 лип. 2026 р. о 09:25 Uwe Kleine-König
> <[email protected]> пише:
> >
> > Hello,
> >
> > On Tue, Jul 21, 2026 at 12:52:28PM +0300, Svyatoslav Ryhel wrote:
> > > From: Michał Mirosław <[email protected]>
> > >
> > > Support Nuvoton NPCE795-based ECs as used in Asus Transformer TF201,
> > > TF300T, TF300TG, TF300TL and TF700T pad and dock, as well as TF101 dock
> > > and TF600T, P1801-T and TF701T pad. This is a glue driver handling
> > > detection and common operations for EC's functions.
> > >
> > > Co-developed-by: Svyatoslav Ryhel <[email protected]>
> > > Signed-off-by: Svyatoslav Ryhel <[email protected]>
> > > Signed-off-by: Michał Mirosław <[email protected]>
> >
> > Documentation/process/submitting-patches.rst has:
> >
> >         [...] the ordering of Signed-off-by: tags should reflect the
> >         chronological history of the patch insofar as possible [...]
> >
> > So your S-o-b should be last when you submit a patch.
> >
> > > +#include <linux/i2c.h>
> > > [...]
> > > +#include <linux/mod_devicetable.h>
> >
> > <linux/mod_devicetable.h> will go away soon. Please rely on
> > <linux/i2c.h> to provide a definition of struct of_device_id and drop
> > the #include of mod_devicetable.h.
> >
> > > +static const struct of_device_id asus_ec_match[] = {
> > > +     {
> > > +             .compatible = "asus,sl101-ec-dock",
> > > +             .data = &asus_ec_sl101_dock_data
> > > +     }, {
> > > +             .compatible = "asus,tf101-ec-dock",
> > > +             .data = &asus_ec_tf101_dock_data
> > > +     }, {
> > > +             .compatible = "asus,tf201-ec-pad",
> > > +             .data = &asus_ec_tf201_pad_data
> > > +     }, {
> > > +             .compatible = "asus,tf600t-ec-pad",
> > > +             .data = &asus_ec_tf600t_pad_data
> > > +     },
> > > +     { /* sentinel */ }
> > > +};
> >
> > Trailing comma after the assignments to .data please.
> >
> 
> Sure, but out of curiosity, why in this case you ask for trailing
> comma and if entries are in one line, you don't.

Because this is the most used style. The rationale for the trailing
comma is that if you want to add a new assignment to a multiline
initializer you have to touch the line without comma:

 	}, {
 		.compatible = "asus,tf600t-ec-pad",
-		.data = &asus_ec_tf600t_pad_data
+		.data = &asus_ec_tf600t_pad_data,
+		.something_else = &foobar,
 	},

so if the comma is already there, the patch reduces to:

 	}, {
 		.compatible = "asus,tf600t-ec-pad",
 		.data = &asus_ec_tf600t_pad_data,
+		.something_else = &foobar,
 	},

. For adding a new assignment to:

 	{ .compatible = "..." }

you have to touch the line anyhow, so there is no advantage to already
have the comma. And then it seems parsimony prevails.

Best regards
Uwe

signature.asc (application/pgp-signature, 488 B)