Re: [PATCH] HID: i2c-hid: goodix: Disable VDD on VDDIO enable failure

Doug Anderson <[email protected]> Fri, 31 Jul 2026 10:08:26 -0700

Newsgroups	org.kernel.vger.linux-input,org.kernel.vger.linux-kernel
Message-ID	<CAD=FV=XkFCqreB_70m1f0gZd50mU6AQLEfF4WBXOBqnYNpvijg@mail.gmail.com>

Hi,

On Wed, Jul 22, 2026 at 2:37 AM Chao Huang <[email protected]> wrote:
>
> From: Chao Huang <[email protected]>
>
> If enabling VDDIO fails after VDD has been enabled, the power-up
> path returns without disabling VDD. This leaves the regulator enabled
> and its enable count unbalanced.
>
> Disable VDD before returning the VDDIO error.
>
> Fixes: eb16f59e8e58 ("HID: i2c-hid: goodix: Add mainboard-vddio-supply")
> Signed-off-by: Chao Huang <[email protected]>
> ---
>  drivers/hid/i2c-hid/i2c-hid-of-goodix.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Thanks for the fix.

Reviewed-by: Douglas Anderson <[email protected]>