Re: [PATCH v6] HID: logitech-hidpp: Add support for HID++ Multi-Platform feature (0x4531)

[email protected] Sun, 02 Aug 2026 11:58:11 +0000
Newsgroups org.kernel.vger.linux-input
Message-ID <[email protected]>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit message claims to add specific device IDs and remove quirks, but the patch does not modify any device ID tables or quirks file.
--

--- Patch [1]: [PATCH v6] HID: logitech-hidpp: Add support for HID++ Multi-Platform feature (0x4531) ---
commit 2283951914fe82c9f82d572a2c1e9090262e500b
Author: Baraa Atta (Dev Exalt) <[email protected]>

HID: logitech-hidpp: Add support for HID++ Multi-Platform feature (0x4531)

Add support in the Logitech HID++ driver for the HID++ Multi-Platform
feature (0x4531), which enables HID++ devices to adjust their behavior
based on the host operating system.

> This patch:
>  * Adds device IDs for MX Keys S (046d) and Casa Keys (046d).

[Severity: Medium]
The commit message claims to add specific device IDs for MX Keys S and Casa
Keys, and the v6 changelog mentions removing them from hid-quirks.c, but the
patch diff does not modify any device ID tables or quirks files. Were these
changes accidentally dropped during a rebase or intended for a separate patch?

-- 
Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=1