Re: [PATCH] HID: logitech-hidpp: Remove duplicate ID for the G703 Hero over USB

Jiri Kosina <[email protected]> Mon, 3 Aug 2026 20:25:45 +0200 (CEST)

Newsgroups	org.kernel.vger.linux-input,org.kernel.vger.linux-kernel
Message-ID	<[email protected]>

On Mon, 27 Jul 2026, Bastien Nocera wrote:

> > The ID appears to be given twice, remove the duplicate
> > 
> > Signed-off-by: Stuart Hayhurst <[email protected]>
> 
> Indeed, at line 4652:
>         { /* Logitech G703 Hero Gaming Mouse over USB */
>           HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC090) },
>         { /* Logitech G900 Gaming Mouse over USB */
>           HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC081) },
>         { /* Logitech G903 Gaming Mouse over USB */
>           HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC086) },
>         { /* Logitech G Pro Gaming Mouse over USB */
>           HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC088) },
>         { /* MX Vertical over USB */
>           HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC08A) },
>         { /* Logitech G703 Hero Gaming Mouse over USB */
>           HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC090) },
> 
> Benjamin, Jiri, is there not a way to detect duplicates like this?

I think the modern way to do this is to ask some LLM to find all of them 
:)

> In any case, looks good to me.
> 
> Reviewed-by: Bastien Nocera <[email protected]>

Thanks a lot, now queued.

-- 
Jiri Kosina
SUSE Labs