Re: [PATCH] HID: logitech-hidpp: Remove duplicate ID for the G703 Hero over USB
Bastien Nocera <[email protected]> Mon, 03 Aug 2026 21:09:11 +0200
| Newsgroups | org.kernel.vger.linux-input,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On Mon, 2026-08-03 at 20:25 +0200, Jiri Kosina wrote: > On Mon, 27 Jul 2026, Bastien Nocera wrote: >=20 > > > The ID appears to be given twice, remove the duplicate > > >=20 > > > Signed-off-by: Stuart Hayhurst <[email protected]> > >=20 > > Indeed, at line 4652: > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 { /* Logitech G703 Hero Gami= ng Mouse over USB */ > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 HID_USB_DEVICE(U= SB_VENDOR_ID_LOGITECH, 0xC090) }, > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 { /* Logitech G900 Gaming Mo= use over USB */ > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 HID_USB_DEVICE(U= SB_VENDOR_ID_LOGITECH, 0xC081) }, > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 { /* Logitech G903 Gaming Mo= use over USB */ > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 HID_USB_DEVICE(U= SB_VENDOR_ID_LOGITECH, 0xC086) }, > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 { /* Logitech G Pro Gaming M= ouse over USB */ > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 HID_USB_DEVICE(U= SB_VENDOR_ID_LOGITECH, 0xC088) }, > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 { /* MX Vertical over USB */ > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 HID_USB_DEVICE(U= SB_VENDOR_ID_LOGITECH, 0xC08A) }, > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 { /* Logitech G703 Hero Gami= ng Mouse over USB */ > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 HID_USB_DEVICE(U= SB_VENDOR_ID_LOGITECH, 0xC090) }, > >=20 > > Benjamin, Jiri, is there not a way to detect duplicates like this? >=20 > I think the modern way to do this is to ask some LLM to find all of > them=20 > :) I meant a deterministic way, so I guess that's a no. Cheers >=20 > > In any case, looks good to me. > >=20 > > Reviewed-by: Bastien Nocera <[email protected]> >=20 > Thanks a lot, now queued.