Re: [PATCH v2] HID: intel-ish-hid: ignore post-init ENUM_DEVICES from firmware

Jiri Kosina <[email protected]> Mon, 3 Aug 2026 21:57:06 +0200 (CEST)
Newsgroups org.kernel.vger.linux-input
Message-ID <[email protected]>
On Mon, 20 Jul 2026, Wahid7852 wrote:

> From: Wahid Khan <[email protected]>
> 
> Some ISH firmware versions (observed on Tiger Lake LP, 8086:a0fc,
> GUID {33AECD58-B679-4E54-9BD9-A04D34F0C226}) periodically re-send an
> unsolicited HOSTIF_DM_ENUM_DEVICES response roughly every 79 seconds.
> 
> The current guard collapses two distinct cases into one condition:
> 
>   if (!(response_flag) || init_done)  ->  bad packet + ish_hw_reset
> 
> This incorrectly treats a valid post-init firmware announcement as a
> corrupted packet, triggering an ISH soft-reset and a full ISHTP
> re-initialisation cycle on each occurrence (~1100 times per day on
> affected hardware).
> 
> Split the check: reject messages with no response flag as before, but
> simply discard valid ENUM_DEVICES messages that arrive after init is
> complete.
> 
> Signed-off-by: Wahid Khan <[email protected]>

Applied, thanks.

-- 
Jiri Kosina
SUSE Labs