Re: [PATCH v2] HID: playstation: Support DualSense player LED brightness control

Hi Roderick!

Thank you for your reply! Yes, this is true unfortunately=2E=2E=2E Applica=
tions would need to look at the max_brightness instead of assuming how the =
LEDs behave=2E

One thing that comes to my mind is that we could add a module parameter (e=
=2Eg=2E player_led_brightness_enabled =3D 0/1) and only expose the brightne=
ss adjustment when the parameter is set=2E The default behavior would stay =
the same as it is now (max_brightness =3D 1)=2E

Unfortunately it doesn't prevent manufacturers from shipping OS images wit=
h the parameter overridden to 1 by default and breaking applications' expec=
tations just the same=2E But I don't see any other way around this=2E

Would the module parameter address your concerns?

Regards,
Kate