Re: [PATCH v4] Input: xpad - add support for Beitong KP series controllers

[email protected] Tue, 04 Aug 2026 13:59:18 +0800
Newsgroups org.kernel.vger.linux-input
Message-ID <[email protected]>
On Mon, Aug 04, 2026 at XX:XX, sashiko-bot wrote:
> [High] Contradictory Vendor ID for KP40D between xpad table (0x20bc)
> and HID quirks (0x20dd).

Both are correct. The KP40D wireless dongle is a composite USB device
that exposes two interfaces with different VIDs:
  - 20bc:515c  XInput interface, handled by xpad
  - 20dd:515c  HID interface, kept alive by HID_QUIRK_ALWAYS_POLL

> [Medium] usb_control_msg_recv() with sizeof(ms_os_desc)=128 will
> unconditionally fail with -EREMOTEIO on short reads.

This is not an issue in practice. The device locks correctly on all
four tested PIDs (5126/5128/515b/515c). The response data from these
requests is not consumed — the act of sending the MS OS descriptor
request sequence is what triggers the firmware lock. If any request
returns -EREMOTEIO on a particular platform, the dev_warn() is
informational and does not block probe.

Thanks for the review.