Re: [PATCH v7 0/8] HID: steelseries: split out Arctis driver and add Nova 5X/Nova 7 support

Benjamin Wheeler <[email protected]> Tue, 4 Aug 2026 20:26:50 -0400
Newsgroups org.kernel.vger.linux-input,org.kernel.vger.linux-kernel
Message-ID <[email protected]>
I'm glad to hear this is getting merged! I have studied and tested older 
revisions of Sriman's patchset on my Arctis 7 Gen2 and would love to 
contribute a patch that adds support for it as well. I see you have a 
branch called for-7.3/steelseriesĀ in the hid kernel fork. Should I base 
my patchset off that? And should I aim to have this ready before the 7.3 
merge window, or would 7.4 be more realistic? Thanks for the direction.

Sincerely,

Benjamin Wheeler


P.S. And thanks for working on this, Sriman!


On 8/3/26 3:32 PM, Jiri Kosina wrote:
> On Mon, 3 Aug 2026, Sriman Achanta wrote:
>
>> This series moves the SteelSeries Arctis headset support out of
>> hid-steelseries.c into its own module, reworks it around a per-model
>> device_info table, hardens the battery power-supply lifetime, adds an
>> asynchronous status interface, and finally adds support for the Arctis
>> Nova 5X and Nova 7 families. After the split, hid-steelseries.c is left
>> handling the SRW-S1 racing wheel and the MSI RGB LED devices.
>>
>> Changes since v6:
>>   - Rebased onto hid.git#for-7.3/steelseries.
>>     - The split now leaves the MSI RGB code in hid-steelseries.c
>>       alongside SRW-S1, and strips only the headset members from
>>       struct steelseries_device. The MSI RGB quirk bit is renumbered
>>       to BIT(1) since the two Arctis bits are gone.
>>     - The Arctis hardening that came with the MSI commit moves into
>>       hid-steelseries-arctis.c with the rest of the headset code: the
>>       hdev->rsize < 3 guard in steelseries_is_vendor_usage_page(), the
>>       battery_registered store/load-acquire pair, the !sd checks, and
>>       the hid_hw_stop() on the hid_hw_open() error path. The
>>       steelseries_is_headset() dispatch is dropped, as the new module
>>       only binds headsets. The battery_registered flag then goes away
>>       in patch 3, where the device_info rework guards every
>>       power_supply_changed() on sd->battery instead.
>>     - The v6 patch "HID: steelseries: Inline and simplify SRWS1 wheel
>>       driver" is dropped. Its premise was that hid-steelseries.c only
>>       handles the SRW-S1 after the split, which is no longer true.
>>   - No other changes. The resulting hid-steelseries-arctis.c is
>>     byte-identical to v6.
> Thanks a lot for such a brisk rebase. Now queued.
>