Re: [PATCH v4 10/13] platform/x86: uniwill-wmi: use devm_blocking_notifier_chain_register()

Uwe Kleine-König <[email protected]> Mon, 10 Aug 2026 06:23:55 +0200

Newsgroups	org.kernel.vger.linux-input,org.kernel.vger.linux-acpi,org.kernel.vger.linux-gpio,org.kernel.vger.linux-iio,org.kernel.vger.linux-kernel,org.kernel.vger.linux-pwm,org.kernel.vger.platform-driver-x86
Message-ID	<anlSAqWxS7boyJBT@monoceros>

Hello,

On Sun, Jul 26, 2026 at 10:17:36AM +0000, Eliav Farber wrote:
>  int devm_uniwill_wmi_register_notifier(struct device *dev, struct notifier_block *nb)
>  {
> -	int ret;
> -
> -	ret = blocking_notifier_chain_register(&uniwill_wmi_chain_head, nb);
> -	if (ret < 0)
> -		return ret;
> -
> -	return devm_add_action_or_reset(dev, devm_uniwill_wmi_unregister_notifier, nb);
> +	return devm_blocking_notifier_chain_register(dev,
> +						     &uniwill_wmi_chain_head,
> +						     nb);
>  }

I'd remove this function and replace calls to it directly by
devm_blocking_notifier_chain_register().

Best regards
Uwe

signature.asc (application/pgp-signature, 488 B)