Re: [PATCH v5] HID: pulsar: add driver for Pulsar gaming mice

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Mismatch between vendor and device IDs in `pulsar_table` preventing binding for ATK VXE R1 SE+.
--

--- Patch [1]: [PATCH v5] HID: pulsar: add driver for Pulsar gaming mice ---
commit 77c96d32e01f202616edca1e5d0c2f9591dce152
Author: Nikolas Koesling <[email protected]>
Date:   Sat Aug 15 23:32:40 2026 +0000

    HID: pulsar: add driver for Pulsar gaming mice
    
Add a HID driver for Pulsar wireless gaming mice and related devices.
The driver provides battery level, voltage, and charging status via the
power supply framework.

> diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
> index 1059922baaacd..7a73fda02a0f2 100644
> --- a/drivers/hid/hid-ids.h
> +++ b/drivers/hid/hid-ids.h
> @@ -251,6 +251,12 @@
>  #define USB_VENDOR_ID_ATMEL_V_USB	0x16c0
>  #define USB_DEVICE_ID_ATMEL_V_USB	0x05df
>  
> +#define USB_VENDOR_ID_ATK	0x373B
> +#define USB_DEVICE_ID_ATK_VXE_R1_SE_WIRED	0xF58F
> +
> +#define USB_VENDOR_ID_ATK_ALT		0x3554
> +#define USB_DEVICE_ID_ATK_VXE_R1_SE_DONGLE	0x1085

[ ... ]

> diff --git a/drivers/hid/hid-pulsar.c b/drivers/hid/hid-pulsar.c
> new file mode 100644
> index 0000000000000..b90284a00776a
> --- /dev/null
> +++ b/drivers/hid/hid-pulsar.c

[ ... ]

> +static const struct hid_device_id pulsar_table[] = {

[ ... ]

> +	{ HID_USB_DEVICE(USB_VENDOR_ID_KYSONA, USB_DEVICE_ID_KYSONA_M600_WIRED),
> +	  .driver_data = TYPE_KYSONA },
> +	{ HID_USB_DEVICE(USB_VENDOR_ID_ATK, USB_DEVICE_ID_ATK_VXE_R1_SE_DONGLE),
> +	  .driver_data = TYPE_ATK },
> +	{ HID_USB_DEVICE(USB_VENDOR_ID_ATK_ALT, USB_DEVICE_ID_ATK_VXE_R1_SE_WIRED),
> +	  .driver_data = TYPE_ATK },

[Severity: Medium]
Are the vendor and device IDs for the ATK VXE R1 SE+ swapped here compared
to their definitions?

In hid-ids.h, USB_VENDOR_ID_ATK is grouped with the WIRED device ID, and
USB_VENDOR_ID_ATK_ALT is grouped with the DONGLE device ID. However,
pulsar_table assigns the DONGLE ID to the regular vendor ID and the
WIRED ID to the ALT vendor ID.

Could this prevent the driver from properly binding to the ATK VXE R1 SE+
hardware?

> +	{ HID_USB_DEVICE(USB_VENDOR_ID_VXE, USB_DEVICE_ID_VXE_DRAGONFLY_R1_PRO_DONGLE),
> +	  .driver_data = TYPE_VXE },

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1