Re: [PATCH] Add support for HyperX cloud 2 wireless.
Sofia Schneider <[email protected]>
| Newsgroups | org.kernel.vger.linux-input,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <CAMoDTWjF6D0PNyf8sa7x3zO5+ZEn3pnvGftH7+HM7NDqNv2G8A@mail.gmail.com> |
On Thu, Aug 13, 2026 at 12:53 PM Idan Koblik <[email protected]> wrote: > Add the device ID for HyperX cloud 2 wireless, which requires > the same handling as the devices support by this driver. > > Tested with HyperX cloud 2 wireless. > > Signed-off-by: Idan Koblik <[email protected]> Hi Idan, Thanks for the patch! The code looks good, but the commit subject and message need a little editing to match kernel standards: 1. Please add "HID: hp: " as a prefix to the subject and remove the trailing period: HID: hp: Add support for HyperX Cloud II Wireless 2. The note in parentheses (about your GitHub repo) should be moved below the "---" line so it doesn't appear in the permanent git log, or removed. With those fixed in v2: Reviewed-by: Sofia Schneider <[email protected]> Note for Jiri/Benjamin: This patch applies on top of my pending v4 driver patch ([PATCH v4] HID: hp: Add support for HyperX headset devices)