Re: [PATCH] Input: synaptics - disable InterTouch on ThinkPad T440p (board id 2722)

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Format string specifier mismatch in psmouse_info: using `%d` for `u32` variable.
--

--- Patch [1]: [PATCH] Input: synaptics - disable InterTouch on ThinkPad T440p (board id 2722) ---
commit 4b10eb76fbd26fd6245ba466bd6e79e874e7afbb
Author: Raphaël Larocque <[email protected]>

Input: synaptics - disable InterTouch on ThinkPad T440p (board id 2722)

This commit disables SMBus InterTouch for the Lenovo ThinkPad T440p (PNP ID
LEN0036, board id 2722) by default. This addresses an issue where the SMBus
companion takes too long to appear at boot, causing the touchpad to become
unresponsive.

> diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
> index 2170bbe4c5897..141d58a716180 100644
> --- a/drivers/input/mouse/synaptics.c
> +++ b/drivers/input/mouse/synaptics.c
[ ... ]
> @@ -1838,6 +1838,16 @@ static int synaptics_setup_intertouch(struct psmouse *psmouse,
[ ... ]
> +		/* Disable intertouch on known-broken board revisions */
> +		if (psmouse_matches_pnp_id(psmouse,
> +				(const char * const []){"LEN0036", NULL}) &&
> +		    info->board_id == 2722) {
> +			psmouse_info(psmouse,
> +				     "Disabling intertouch for board id %d\n",
> +				     info->board_id);

[Severity: Low]
Since info->board_id is defined as a u32 (unsigned 32-bit integer) in struct
synaptics_device_info, should this format specifier be %u instead of %d to
avoid strict type warnings?

> +			return -ENXIO;
> +		}
>  	}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1