[PATCH 0/5] HID: hid-lenovo-go: fix controller configuration
Aditya Dash <[email protected]>
| Newsgroups | org.kernel.vger.linux-input,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
The hid-lenovo-go driver exposes controller configuration attributes, but several requests use incorrect fields or report the wrong result. Calibration uses reversed command fields, FPS mode DPI includes an extra device byte, firmware calibration failure appears as unknown, and two right-controller attributes use the wrong selectors. The first four patches correct those declarations and request layouts. The last patch fixes the shared synchronous request path so that only the matching reply completes a request and transport, firmware, interruption, and timeout errors reach the caller. It uses the corrected calibration command pairs from the first patch. Calibration completion is asynchronous. The driver now submits those commands without waiting for an immediate reply and continues to receive final state through the existing completion report. Firmware does not provide a sequence number, so a late reply with the same complete command tuple remains indistinguishable from a newer reply. Aditya Dash (5): HID: hid-lenovo-go: use the correct calibration commands HID: hid-lenovo-go: fix the FPS mode DPI request HID: hid-lenovo-go: record calibration completion state HID: hid-lenovo-go: use the right controller selectors HID: hid-lenovo-go: return configuration request errors drivers/hid/hid-lenovo-go.c | 165 +++++++++++++++++++++++++++--------- 1 file changed, 127 insertions(+), 38 deletions(-) base-commit: 1292bca0f8d835d2ad96d309595b2e97f3106d3d -- 2.55.0