Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `hid-universal-pidff.c` driver contains a hardcoded loop bound (`ABS_BRAKE`) for racing axis initialization, leaving the newly added racing axes without correct fuzz and deadzone configuration.
--
--- Patch [10]: [PATCH v4 10/12] Input: Add ABS_CLUTCH, HANDBRAKE, and SHIFTER ---
commit 518c533c53885e9a0bf15581d9e84560c1f27740
Author: Vicki Pfau <[email protected]>
Input: Add ABS_CLUTCH, HANDBRAKE, and SHIFTER
This commit introduces new absolute axes (ABS_CLUTCH, ABS_HANDBRAKE, and
ABS_SHIFTER) for racing game controllers. It updates the relevant definitions
in input-event-codes.h and the debug string representations in the HID
subsystem.
[ ... ]
> diff --git a/include/uapi/linux/input-event-codes.h b/include/uapi/linux/input-event-codes.h
> index 3528168f7c6d7..5c881ed441771 100644
> --- a/include/uapi/linux/input-event-codes.h
> +++ b/include/uapi/linux/input-event-codes.h
> @@ -879,6 +879,9 @@
> #define ABS_WHEEL 0x08
> #define ABS_GAS 0x09
> #define ABS_BRAKE 0x0a
> +#define ABS_CLUTCH 0x0b
> +#define ABS_HANDBRAKE 0x0c
> +#define ABS_SHIFTER 0x0d
[Severity: Medium]
Will these newly added axes be missing fuzz and deadzone configuration in
some drivers?
Looking at universal_pidff_input_configured() in
drivers/hid/hid-universal-pidff.c, there is a hardcoded loop bound that
explicitly terminates at ABS_BRAKE:
/* Decrease fuzz and deadzone on available axes */
for (axis = ABS_X; axis <= ABS_BRAKE; axis++) {
Does this loop need to be updated to include ABS_CLUTCH, ABS_HANDBRAKE,
and ABS_SHIFTER, since they logically belong in this racing axes group
and might otherwise incorrectly retain default settings?
--
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=10
lmpx.com only provides a reader for public news (NNTP) servers. It is not
affiliated with the servers or forums shown here and is not responsible for
the content of articles, which is written by their respective authors.