Re: [PATCH] tpm: eventlog: remove unused structs tcg_algorithm_{size,info}

Jarkko Sakkinen <[email protected]>
Newsgroups org.kernel.vger.linux-integrity,org.kernel.vger.linux-kernel
Message-ID <[email protected]>
On Fri, Apr 17, 2026 at 12:55:17PM +0200, Thorsten Blum wrote:
> Remove the unused structs tcg_algorithm_size and tcg_algorithm_info.
> 
> Signed-off-by: Thorsten Blum <[email protected]>
> ---
>  include/linux/tpm_eventlog.h | 16 ----------------
>  1 file changed, 16 deletions(-)
> 
> diff --git a/include/linux/tpm_eventlog.h b/include/linux/tpm_eventlog.h
> index aff8ea2fa98e..615bd0af5173 100644
> --- a/include/linux/tpm_eventlog.h
> +++ b/include/linux/tpm_eventlog.h
> @@ -114,22 +114,6 @@ struct tcg_pcr_event2_head {
>  	struct tpm_digest digests[];
>  } __packed;
>  
> -struct tcg_algorithm_size {
> -	u16 algorithm_id;
> -	u16 algorithm_size;
> -};
> -
> -struct tcg_algorithm_info {
> -	u8 signature[16];
> -	u32 platform_class;
> -	u8 spec_version_minor;
> -	u8 spec_version_major;
> -	u8 spec_errata;
> -	u8 uintn_size;
> -	u32 number_of_algorithms;
> -	struct tcg_algorithm_size digest_sizes[];
> -};
> -
>  #ifndef TPM_MEMREMAP
>  static inline void *TPM_MEMREMAP(unsigned long start, size_t size)
>  {

NAK. If you are doing something useful here then it is fine.

The only feature that pure cleanup patches cause are potential merge
conflicts when backporting actual bug fixes.

BR, Jarkko
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.