Re: [PATCH] tpm: tpm_tis: Add optional delay after relinquish

Jim Broadus <[email protected]>
Newsgroups org.kernel.vger.linux-integrity,org.kernel.vger.linux-kernel
Message-ID <[email protected]>
Hi Jarkko. The current manufacturer_id is in tpm_tis_data, not tpm_chip. 
I think it makes sense to move the new did_vid to tpm_chip so it can be 
used in tpm-sysfs, but it would only be set (at least initially) for the 
tpm_tis driver. What do you think?

Thank you,
Jim

On 5/22/26 5:37 AM, Jarkko Sakkinen wrote:
> On Thu, May 21, 2026 at 11:03:29PM -0700, Jim Broadus wrote:
>> Thank you Jarkko. I'll do that.
>>
>> Jim
> Yeah, in this form it is quite unsable e.g., for any Linux distribution,
> and somewhat involved for the user :-)
>
> Conditionally on is much better with appropriate detection. Also, this
> way the change improves the code base a bit given that chip->did_vid is
> much more applicable than chip->manufaturer_id.
>
> BR, Jarkko
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.