Re: [PATCH 05/18] rust: kbuild: define `procmacro-extension` variable
Miguel Ojeda <[email protected]>
| Newsgroups | org.kernel.vger.linux-kbuild,org.kernel.vger.rust-for-linux |
|---|---|
| Message-ID | <CANiq72nWBSTXz8VBkMuf_Bcs2MgZ31nocL3o_s7HYv=HbVK_-g@mail.gmail.com> |
On Mon, Jun 8, 2026 at 5:10 PM Nicolas Schier <[email protected]> wrote: > > Where does the 'libname.%' pattern come from? Looking at the current > users of cmd_rustc_procmacro I'd expect a 'lib%' pattern instead. Here, we want to extract the extension the operating system uses -- this was originally added for macOS build support (Cc Tamir), and is `.so` in Linux but `.dylib` there (and if I recall correctly, we couldn't force `rustc` in macOS to use a file with `.so` as the extension, sadly). In the commands, however, what we are trying to extract is the name of the crate instead. So that is why one is `lib%` and the other `libname.%` (a dummy library name). Or do you mean something else? Thanks a lot for the reviews! By the way, I sent a bit ago v2 (it doesn't change much, so I will pick your tags from here :) Cheers, Miguel