[PATCH] modpost: release allocation when early return no suffix .o in read_symbols()
Robertus Diawan Chris <[email protected]>
| Newsgroups | org.kernel.vger.linux-kbuild,dev.linux.lists.linux-kernel-mentees,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
The allocation for elf info symsearch and hdr from parse_elf() haven't
been released when return because of modname didn't have suffix ".o".
So, release the allocation before early return because of modname
without suffix ".o".
This is reported by Coverity Scan as "Resource leak".
Fixes: 8c9ce89c5b63 ("modpost: simplify mod->name allocation")
Signed-off-by: Robertus Diawan Chris <[email protected]>
---
scripts/mod/modpost.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
index abbcd3fc1394..8e231544f9f3 100644
--- a/scripts/mod/modpost.c
+++ b/scripts/mod/modpost.c
@@ -1585,6 +1585,7 @@ static void read_symbols(const char *modname)
if (!strends(modname, ".o")) {
error("%s: filename must be suffixed with .o\n", modname);
+ parse_elf_finish(&info);
return;
}
base-commit: 4549871118cf616eecdd2d939f78e3b9e1dddc48
--
2.54.0