Re: [PATCH 05/18] rust: kbuild: define `procmacro-extension` variable

Miguel Ojeda <[email protected]>
Newsgroups org.kernel.vger.linux-kbuild,org.kernel.vger.rust-for-linux
Message-ID <CANiq72nmPPF=6AUp5mcDJVni80ORQr0AQ-4uCZaE+CzB5kV=eg@mail.gmail.com>
On Tue, Jun 9, 2026 at 1:40 PM Nicolas Schier <[email protected]> wrote:
>
> Ah thanks!  If only that filename extension ('so' or 'dylib') is wanted,
> I'd rather expected the use of the '$(suffix)' function instead, as it
> may be easier to understand w/o knowing the name conversion rustc does:
>
>   procmacro-extension := $(suffix $(call procmacro-name,dummy-crate-name))
>
> but that's bike-shedding.

Good point, I didn't consider `suffix` at all, so we can definitely do
that. Do you want to submit a patch?

Although from a quick test, `suffix` keeps the period, so we need
changes elsewhere (also we cannot use `-` in the crate name, so
`dummy` or the current `name` should suffice).

Thanks!

Cheers,
Miguel
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.