Re: [PATCH v4 3/7] bootconfig: render embedded bootconfig as a kernel cmdline at build time
Breno Leitao <[email protected]>
| Newsgroups | org.kernel.vger.linux-kbuild,org.kernel.vger.bpf,org.kernel.vger.linux-kernel,org.kernel.vger.linux-trace-kernel |
|---|---|
| Message-ID | <[email protected]> |
Hello Julian, On Wed, Jun 10, 2026 at 02:44:52PM +0100, Julian Braha wrote: > On 6/9/26 11:28, Breno Leitao wrote: > > + depends on BOOT_CONFIG_EMBED > > + depends on BOOT_CONFIG_EMBED_FILE != "" > > Hi Breno, > > Just an FYI, this dependency on BOOT_CONFIG_EMBED is redundant because > the: > BOOT_CONFIG_EMBED_FILE != "" > is only possible when BOOT_CONFIG_EMBED is enabled. Good catch, thanks. BOOT_CONFIG_EMBED_FILE itself already depends on BOOT_CONFIG_EMBED, so the explicit line is redundant. I'll drop it! Thanks for the review, --breno