Ironic visualization in menuconfig for NTFS_FS vs NTFS3_FS
Xi Ruoyao <[email protected]>
| Newsgroups | org.kernel.vger.linux-kbuild,org.kernel.vger.linux-fsdevel,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
Hi,
In the Kconfig for NTFS3 we now have:
config NTFS3_FS
tristate "NTFS Read-Write file system support"
depends on !NTFS_FS || m
It basically means some sort of conflict between NTFS_FS and NTFS3_FS.
But then menuconfig is apparently puzzled to believe NTFS3_FS "depends
on" NTFS_FS, and put NTFS3_FS as a subentry of NTFS_FS:
│ │ <M> NTFS file system support │ │
│ │ [ ] NTFS debugging support (NEW) │ │
│ │ [ ] NTFS POSIX Access Control Lists (NEW) │ │
│ │ <M> NTFS Read-Write file system support │ │
│ │ [ ] 64 bits per NTFS clusters │ │
│ │ [*] activate support of external compressions lzx/xpress │ │
│ │ [ ] NTFS POSIX Access Control Lists │
This is really ironic (some opposite of the intention of the depends on
line) and it can easily puzzle new kernel developers into wrongly
believing "NTFS3_FS is a extension of NTFS_FS providing write support."
I can "work it around" with:
--- a/fs/ntfs3/Kconfig
+++ b/fs/ntfs3/Kconfig
@@ -1,7 +1,11 @@
# SPDX-License-Identifier: GPL-2.0-only
+config NO_NTFS
+ bool
+ default !NTFS_FS
+
config NTFS3_FS
tristate "NTFS Read-Write file system support"
- depends on !NTFS_FS || m
+ depends on NO_NTFS || m
select BUFFER_HEAD
select NLS
select LEGACY_DIRECT_IO
but maybe Kconfig should just handle this better. Thoughts?
--
Xi Ruoyao <[email protected]>