Re: [PATCH] kbuild: remove srctreie path from CHECK output

Nathan Chancellor <[email protected]> Mon, 29 Jun 2026 19:32:37 -0700
Newsgroups org.kernel.vger.linux-kbuild,org.kernel.vger.linux-kernel
Message-ID <178278675710.3414597.12868097497271294239.b4-review@b4>
On Mon, 22 Jun 2026 14:26:53 +0100, Ben Dooks <[email protected]> wrote:

Hi Ben,

There is a typo in the subject.

>
> diff --git a/scripts/Makefile.build b/scripts/Makefile.build
> index 911745743246..d432693e5367 100644
> --- a/scripts/Makefile.build
> +++ b/scripts/Makefile.build
> @@ -159,10 +159,10 @@ targets += $(targets-for-builtin) $(targets-for-modules)
>  
>  # Linus' kernel sanity checking tool
>  ifeq ($(KBUILD_CHECKSRC),1)
> -  quiet_cmd_checksrc       = CHECK   $<
> +  quiet_cmd_checksrc       = CHECK   $(patsubst $(srctree)/%,%,$<)
>          cmd_checksrc       = $(CHECK) $(CHECKFLAGS) $(c_flags) $<
>  else ifeq ($(KBUILD_CHECKSRC),2)
> -  quiet_cmd_force_checksrc = CHECK   $<
> +  quiet_cmd_force_checksrc = CHECK   $(patsubst $(srctree)/%,%,$<)
>          cmd_force_checksrc = $(CHECK) $(CHECKFLAGS) $(c_flags) $<
>  endif
>  

I don't have a strong objection to this patch but I know there are
plenty of other places in the build log that will use a full source
path, so this doesn't fully address that inconsistency (and I am not
sure it is inconsistent to begin with, as most build targets are
relative to the build directory whereas files from the source tree have
to be absolute when the build is done outside the tree). But this seems
reasonable enough.

Acked-by: Nathan Chancellor <[email protected]>

-- 
Cheers,
Nathan