Re: [PATCH 3/7] MIPS: csrc-r4k: Replace CONFIG_GENERIC_GETTIMEOFDAY ifdeffery with IS_ENABLED()
Thomas Gleixner <[email protected]> Wed, 15 Jul 2026 11:03:47 +0200
| Newsgroups | org.kernel.vger.linux-kbuild,dev.linux.lists.loongarch,org.infradead.lists.linux-arm-kernel,org.infradead.lists.linux-riscv,org.kernel.vger.linux-arch,org.kernel.vger.linux-kernel,org.kernel.vger.linux-mips |
|---|---|
| Message-ID | <87tsq0oc98.ffs@fw13> |
On Wed, Jul 15 2026 at 10:43, Thomas Weißschuh wrote: > On Wed, Jul 15, 2026 at 10:25:19AM +0200, Thomas Gleixner wrote: >> and then you can just unconditionally set clocksource::vdso_clock_mode >> in all drivers. >> >> No? > > It will weaken the sanity check in __clocksouce_register_scale() if > CONFIG_GENERIC_GETTIMEOFDAY=n. I am not sure what that sanity check > is supposed to protect against, so I left it as is. > If we can weaken the check, or maybe even remove it, > I'm all for your simpler aproach. The sanity check is there to catch random numbers being assigned. I does not weaken when it's actually unused :)