Re: [PATCH v2 2/2] kbuild: Move gen_init_cpio and gen_initramfs.sh to scripts/
Nicolas Schier <[email protected]> Sat, 1 Aug 2026 21:44:34 +0200
| Newsgroups | org.kernel.vger.linux-kbuild,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <am5Moi6DBgMSnuO1@levanger> |
On Fri, Jul 31, 2026 at 12:36:19PM -0700, Nathan Chancellor wrote: > > diff --git a/usr/gen_init_cpio.c b/scripts/gen_init_cpio.c > > similarity index 100% > > rename from usr/gen_init_cpio.c > > rename to scripts/gen_init_cpio.c > > diff --git a/usr/gen_initramfs.sh b/scripts/gen_initramfs.sh > > similarity index 99% > > rename from usr/gen_initramfs.sh > > rename to scripts/gen_initramfs.sh > > index 7eba2fddf0ef..27ac1fd48001 100755 > > --- a/usr/gen_initramfs.sh > > +++ b/scripts/gen_initramfs.sh > > The cpio commmand in scripts/Makefile.package needs an update for this > move, otherwise modules-cpio-pkg will be broken. Good catch, thanks! > Additionally, I see a number of references to "usr/gen_init" even after > this is applied: > > $ git grep usr/gen_init > Documentation/driver-api/early-userspace/early_userspace_support.rst:usr/gen_init_cpio utility (run 'usr/gen_init_cpio -h' to get the > Documentation/driver-api/early-userspace/early_userspace_support.rst:usr/gen_init_cpio. [...] > tools/testing/selftests/kho/vmtest.sh: "$build_dir/usr/gen_init_cpio" "$tmp_dir/cpio_list" > "$initrd" > tools/testing/selftests/nolibc/Makefile.nolibc: $(QUIET_GEN)echo 'file /init nolibc-test 755 0 0' | $(objtree)/usr/gen_init_cpio - > initramfs.cpio > usr/Kconfig: "usr/gen_init_cpio" program in the kernel tree. oh well, thanks! I completely forgot checking for references. > Otherwise, this seems reasonable to me. Feel free to carry > > Reviewed-by: Nathan Chancellor <[email protected]> > > on the respin. Will do, thank for the review! Nicolas