Re: [PATCH 0/2] modpost: error logging cleanups
Nathan Chancellor <[email protected]>
| Newsgroups | org.kernel.vger.linux-kbuild,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <178613777751.32781.14792177228607560956.b4-review@b4> |
> I was doing some refactoring, and kept hitting modpost errors and > warnings. It was getting a bit annoying that a lot of the modpost > messages have different formats for modules, and different quoting for > symbols, sections, and namespaces. > > Clean them up a bit. > > Jani Nikula (2): > modpost: add module as parameter to modpost_log() > modpost: use mod_warn() and mod_error(), clean up logging > > scripts/mod/modpost.c | 112 +++++++++++++++++++++--------------------- > scripts/mod/modpost.h | 8 +-- > 2 files changed, 60 insertions(+), 60 deletions(-) Thanks, this definitely seems like a nice cleanup! I have definitely noticed how inconsistently modpost messages were formmatted in the past. Reviewed-by: Nathan Chancellor <[email protected]> -- Cheers, Nathan