Re: [PATCH v4 08/12] mips: Get rid of custom mips ABIs for syscall tables

André Almeida <[email protected]>
Newsgroups org.kernel.vger.linux-kbuild,org.kernel.vger.linux-kernel
Message-ID <[email protected]>
Em 12/08/2026 10:11, Arnd Bergmann escreveu:
> On Wed, Aug 12, 2026, at 14:53, André Almeida wrote:
>> Em 12/08/2026 06:16, Arnd Bergmann escreveu:
>>> On Wed, Aug 12, 2026, at 05:33, André Almeida wrote:
>>> I had expected you to use 'common' instead of '32' and '64' here. Since you
>>> did not combine the n32/n64 tables, this makes no practical difference,
>>> but it still makes the tables look different from all the other ones, and
>>> it means that the following patch to unify the tables is harder to
>>> validate since the inputs are still not line-identical.
>>>
>>> Is there some reason you went with this approach?
>>>
>> Ops, no good reason here, it was a mistake :) I will redo it to use
>> common from [1, 211] syscalls.
> 
> I can see this done in one of two ways:
> 
> a) make everything in the mips specific files 'common' and keep the
>     three separate files
> b) make only the first 211 syscalls in n32/n64 common, using compat
>     entries where those differ, then use 32/64 as the ABI for the
>     ones where the numbers went out of sync, and merge the two
>     files into one.
> 
> I've added Thomas Bogendörfer to Cc, he may have an opinion one
> way or the other.
> 

I believe b) is the best option here, as we can remove one more common 
file. I will add Thomas Bogendörfer in Cc for the next round.
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.