Re: [PATCH] scripts: Make the code use consistent syntax

Nathan Chancellor <[email protected]>
Newsgroups org.kernel.vger.linux-kbuild,org.kernel.vger.linux-kernel
Message-ID <178707966024.2113250.6051873542503340409.b4-review@b4>
> The code was using a different form of syntax. So, make it more
> consistent with a similar kind of syntax.

Please make the commit subject and message more descriptive for what is
being modified (scripts/mkcompile_h, not scripts in general) and how/why
it is being modified. What you have is just too generic in my opinion.
Maybe something like

  scripts/mkcompile_h: Update LINUX_COMPILE_HOST command substitution syntax

  The assignment of LINUX_COMPILE_HOST uses the classic backtick style
  for its command substitution but the rest of the script uses the more
  common '$()'. Update LINUX_COMPILE_HOST to match for consistency.

Otherwise, change itself seems fine. I will pick up your next revision
for 7.4 when 7.3-rc1 is out.

-- 
Cheers,
Nathan
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.