Re: [PATCH v2] HID: playstation: Support DualSense player LED brightness control

Hi Roderick!

Thank you for your reply! Yes, this is true unfortunately... Applications would need to look at the max_brightness instead of assuming how the LEDs behave.

One thing that comes to my mind is that we could add a module parameter (e.g. player_led_brightness_enabled = 0/1) and only expose the brightness adjustment when the parameter is set. The default behavior would stay the same as it is now (max_brightness = 1).

Unfortunately it doesn't prevent manufacturers from shipping OS images with the parameter overridden to 1 by default and breaking applications' expectations just the same. But I don't see any other way around this.

Would the module parameter address your concerns?

Regards,
Kate