Re: [PATCH v7 18/23] firmware: arm_scmi: Expose per-instance identifier

Fayssal Benmlih <[email protected]> Mon, 3 Aug 2026 22:57:57 +0000
Newsgroups org.kernel.vger.linux-kernel,org.infradead.lists.linux-arm-kernel,org.kernel.vger.arm-scmi,org.kernel.vger.linux-doc
Message-ID <[email protected]>
Hi Cristian,

One kerneldoc nit inline.

>  * @id: A unique positive natural integer identifying the SCMI Instance
>  *	associated with this handle to be used across all drivers for
>  *	naming purposes: same identifier used internally as the root for
>  *	the debugfs per-instance tree.

SCMI instance numbering includes zero; the first instance is exposed as
tlm_0 and under debugfs instance 0.

Could this say "unique non-negative integer" or simply "unique instance
identifier" rather than "positive natural integer"?

Thanks,
Fayçal