Re: [PATCH v6 0/9] perf c2c: add a function view

Jiebin Sun <[email protected]>
Newsgroups org.kernel.vger.linux-kernel,org.kernel.vger.linux-perf-users
Message-ID <[email protected]>
Hi Namhyung,

Thanks for reporting this. I reproduced the Python import failure. Although
the loader reported c2c_fmt_free, checking with `ldd -r` showed four
unresolved symbols from c2c-function.o: c2c, c2c_fmt_equal, c2c_fmt_free,
and perf_c2c__browse_cacheline.

I considered moving the formatter callbacks to util/ as suggested. However,
that would still leave c2c, the command's global state, and
perf_c2c__browse_cacheline(), its existing TUI entry point, unresolved.

The issue comes from placing c2c-function.o in libperf-ui.a, which is linked
into python/perf.so under --whole-archive, while builtin-c2c.o is not part
of the Python module. Since the browser is specific to the c2c command, v7
links it directly into perf alongside builtin-c2c.o, under CONFIG_SLANG.

This is folded into the browser skeleton patch; the other eight patches are
unchanged. I clean-built every commit and ran `perf test -v 'import perf'`
at each step. I also verified the full series with and without SLANG.

The `--stdio` support and function-view test will follow on top of v7.

Thanks,
Jiebin
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.